Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for walletconnect wallet #703

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

jeffhu1
Copy link
Contributor

@jeffhu1 jeffhu1 commented Sep 22, 2022

Closes #699

@iulianbarbu
Copy link

@michaelhly , should we notify anyone to review this? Please let us know if we can facilitate the review with anything.

@michaelhly
Copy link
Contributor

@jeffhu1 @iulianbarbu can you guys fix the build issue?

Module not found: Error: Can't resolve 'events' in '/home/runner/.yarn/berry/cache/@walletconnect-heartbeat-npm-1.0.0-2a6f7e2ea6-8.zip/node_modules/@walletconnect/heartbeat/dist/cjs'

@jeffhu1
Copy link
Contributor Author

jeffhu1 commented Sep 22, 2022

I think the build issue has to do with webpack 5 in size-limit not polyfilling events

@jeffhu1
Copy link
Contributor Author

jeffhu1 commented Sep 22, 2022

@michaelhly The build should be fixed, works locally!

@michaelhly michaelhly merged commit 4a069f6 into saber-hq:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Walletconnect support
3 participants